chenboat commented on a change in pull request #3877: Pinot controller side
change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#discussion_r261731861
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -204,8 +204,8 @@ public String
segmentCommitEnd(@QueryParam(SegmentCompletionProtocol.PARAM_INSTA
return SegmentCompletionProtocol.RESP_FAILED.toJsonString();
}
- SegmentMetadataImpl segmentMetadata =
extractMetadataFromLocalSegmentFile(segmentName,
- ControllerConf.getUriFromPath(segmentLocation).getPath());
+ SegmentMetadataImpl segmentMetadata =
extractMetadataFromSegmentFile(segmentName,
+ ControllerConf.getUriFromPath(segmentLocation));
Review comment:
I still prefer to use a URI to pass into
extractMetadataFromSegmentFile(.,.) because PinotFS expects an URI in
general. Construct a URI directly instead of calling
ControllerConf.getUriFromPath (which is essentially a thin wrapper).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
