kishoreg commented on issue #3913: Adding the support for sampling logs URL: https://github.com/apache/incubator-pinot/pull/3913#issuecomment-470017142 can we set a maxRate instead of setting samplingRate? we can use the RateLimiter from Gauva to implement this for now. This will make the rate adaptive and at low qps, we will still get all the logs unlike sampling where it will always filter. We can then move to BurstFilter (https://logging.apache.org/log4j/2.0/manual/filters.html#BurstFilter) when we move to log4j2
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
