mcvsubbu commented on a change in pull request #3912: Fix
SegmentGeneratorConfig where the time format in schema is not picked up
URL: https://github.com/apache/incubator-pinot/pull/3912#discussion_r263051156
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
##########
@@ -469,6 +459,28 @@ public Schema getSchema() {
public void setSchema(Schema schema) {
Preconditions.checkNotNull(schema);
_schema = schema;
+
+ // Set time related fields
Review comment:
RealtimeSegmentConverter uses SegmentGeneratorConfig and sets time unit and
time column name independently after constructing it with schema. Perhaps you
can remove those lines form there? And move the TODOs here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
