jackjlli commented on a change in pull request #3864: Add controller mode logic
in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r263075388
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -339,12 +441,19 @@ public void stop() {
LOGGER.info("Stopping resource manager");
_helixResourceManager.stop();
+ LOGGER.info("Stopping rebalance segments factory");
+ RebalanceSegmentStrategyFactory.stop();
+
_executorService.shutdownNow();
} catch (final Exception e) {
LOGGER.error("Caught exception while shutting down", e);
}
}
+ public boolean isPinotOnlyModeSupported() {
+ return _controllerMode != ControllerConf.ControllerMode.PINOT_ONLY;
Review comment:
Addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
