Jackie-Jiang commented on a change in pull request #3864: Add controller mode
logic in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r263202341
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -188,6 +188,8 @@ public void stop() {
}
}
LOGGER.info("Wait completed: Number of completing segments = {}",
_numCompletingSegments.get());
+ INSTANCE = null;
Review comment:
Can you add TODO to fix the misuse of singleton class? This should not be a
singleton class. Same for other classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
