jihaozh commented on a change in pull request #3921: [TE] frontend -
harleyjj/alert-details - fix timeseries fetch
URL: https://github.com/apache/incubator-pinot/pull/3921#discussion_r263619461
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
##########
@@ -597,12 +597,10 @@ export default Component.extend({
analysisRange,
selectedBaseline
} = this.getProperties('metricUrn', 'analysisRange', 'selectedBaseline');
- const granularity = '15_MINUTES';
- const timezone = moment.tz.guess();
set(this, 'errorTimeseries', null);
- const urlCurrent =
`/rootcause/metric/timeseries?urn=${metricUrn}&start=${analysisRange[0]}&end=${analysisRange[1]}&offset=current&granularity=${granularity}&timezone=${timezone}`;
+ const urlCurrent =
`/rootcause/metric/timeseries?urn=${metricUrn}&start=${analysisRange[0]}&end=${analysisRange[1]}&offset=current`;
Review comment:
The time zone should be the frontend's timezone.
Technically, the granularity of the graph should be the granularity for
detection. However, with yaml, we allow the user to monitor in different
granularity in different detection rules. Therefore, multiple granularities
could be used in the in one detection, we don't know which one to show. I
suggest using default time granularity for the metric in preview graph for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
