mcvsubbu commented on a change in pull request #3877: Pinot controller side
change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#discussion_r264934672
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -234,13 +257,43 @@ public String
segmentCommit(@QueryParam(SegmentCompletionProtocol.PARAM_INSTANCE
final SegmentCompletionManager segmentCompletionManager =
SegmentCompletionManager.getInstance();
SegmentCompletionProtocol.Response response =
segmentCompletionManager.segmentCommitStart(requestParams);
- if (response.equals(SegmentCompletionProtocol.RESP_COMMIT_CONTINUE)) {
- // Get the segment and put it in the right place.
- boolean success = uploadSegment(multiPart, instanceId, segmentName,
false) != null;
- response = segmentCompletionManager.segmentCommitEnd(requestParams,
success, false);
+ CommittingSegmentDescriptor committingSegmentDescriptor =
+
CommittingSegmentDescriptor.fromSegmentCompletionReqParams(requestParams);
+ boolean success = false;
+
+ if (response.equals(SegmentCompletionProtocol.RESP_COMMIT_CONTINUE)) {
+ File localTmpFile = null;
+ try {
+ // Get the segment from the form input and put it in the right place.
Review comment:
Wrong comment. Get the segment and put it in a tmp area in the local file
system
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
