jihaozh commented on a change in pull request #3967: [TE] Yaml validator for
maxDuration
URL: https://github.com/apache/incubator-pinot/pull/3967#discussion_r265341682
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/DetectionConfigValidator.java
##########
@@ -90,6 +93,16 @@ public void validateConfig(DetectionConfigDTO
detectionConfig) throws Validation
throw new ValidationException("The detection cron specified is
incorrect. Please verify your cron expression"
+ " using online cron makers.");
}
+ // Validate parameters under properties
+ if (detectionConfig.getProperties() != null) {
+ Long maxDuration = MapUtils.getLong(detectionConfig.getProperties(),
PROP_MAX_DURATION);
Review comment:
The max duration actually not in the properties map. It's in the nested
merge wrapper properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
