sunithabeeram commented on a change in pull request #3942: Set
processingException when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r265736137
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##########
@@ -196,6 +196,8 @@ public void onBecomeDroppedFromOffline(Message message,
NotificationContext cont
String tableNameWithType = message.getResourceName();
String segmentName = message.getPartitionName();
+ _instanceDataManager.deleteSegment(tableNameWithType, segmentName);
Review comment:
After line 184, the segment is unavailable correct; and if it is due to a
move/rebalance, we should count it as an error. We only want to suppress it
when the segment has been 'deleted'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
