chenboat commented on a change in pull request #3941: Pinot server side change
to optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r266561972
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -735,14 +742,45 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
if (_isOffHeap) {
params.withMemoryUsedBytes(_memoryManager.getTotalAllocatedBytes());
}
- SegmentCompletionProtocol.Response commitEndResponse =
_protocolHandler.segmentCommitEnd(params);
+ SegmentCompletionProtocol.Response commitEndResponse;
+ if (!_indexLoadingConfig.isEnableSplitCommitEndWithMetadata()) {
+ commitEndResponse = _protocolHandler.segmentCommitEnd(params);
+ } else {
+ Map<String, File> metadataFiles = new HashMap<>();
+ try {
+ metadataFiles.put(V1Constants.MetadataKeys.METADATA_FILE_NAME,
Review comment:
Let me explore a bit your idea to pass in the metadata files via the Segment
Descriptor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
