npawar commented on a change in pull request #3941: Pinot server side change to
optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r267031148
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
##########
@@ -163,6 +165,11 @@ public boolean isEnableSplitCommit() {
return _instanceDataManagerConfiguration.getBoolean(ENABLE_SPLIT_COMMIT,
false);
}
+ @Override
+ public boolean isEnableSplitCommitEndWithMetadata() {
+ return
_instanceDataManagerConfiguration.getBoolean(ENABLE_SPLIT_COMMIT_END_WITH_METADATA,
true);
+ }
Review comment:
I see Subbu's comments about making default true. But the PR description
says it will be default false. Please update the description in that case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
