sunithabeeram commented on a change in pull request #3994: Adding ORC reader
URL: https://github.com/apache/incubator-pinot/pull/3994#discussion_r267574279
##########
File path:
pinot-orc/src/main/java/org/apache/pinot/orc/data/readers/ORCRecordReader.java
##########
@@ -58,6 +67,24 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(ORCRecordReader.class);
+ @VisibleForTesting
+ public ORCRecordReader(String inputPath) {
+ Configuration conf = new Configuration();
+ try {
Review comment:
Add a init() that takes a path instead of segment-generator config (it can
be a private method). Have this constructor and the public
init(SegmentGeneratorConfig) use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
