This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dfaaf11 [TE] yaml - anomaly filter validation (#4000)
dfaaf11 is described below
commit dfaaf11d9f5318cec5e3b3fc7efad10fdf326698
Author: Jihao Zhang <[email protected]>
AuthorDate: Thu Mar 21 10:54:34 2019 -0700
[TE] yaml - anomaly filter validation (#4000)
---
.../thirdeye/detection/yaml/CompositePipelineConfigTranslator.java | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
index 657efa6..94b3443 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
@@ -460,6 +460,8 @@ public class CompositePipelineConfigTranslator extends
YamlDetectionConfigTransl
Preconditions.checkArgument(yamlConfig.containsKey(PROP_METRIC), "Property
missing " + PROP_METRIC);
Preconditions.checkArgument(yamlConfig.containsKey(PROP_DATASET),
"Property missing " + PROP_DATASET);
Preconditions.checkArgument(yamlConfig.containsKey(PROP_RULES), "Property
missing " + PROP_RULES);
+ Preconditions.checkArgument(!yamlConfig.containsKey(PROP_FILTER),
+ "Please double check the filter config. Adding dimensions filters
should be in the yaml root level using 'filters' as the key. Anomaly filter
should be added in to the indentation level of detection yaml it applies to.");
if (existingConfig != null) {
Map<String, Object> existingYamlConfig = (Map<String, Object>)
this.yaml.load(existingConfig.getYaml());
Preconditions.checkArgument(MapUtils.getString(yamlConfig,
PROP_METRIC).equals(MapUtils.getString(existingYamlConfig, PROP_METRIC)),
"metric name cannot be modified");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
