mcvsubbu commented on a change in pull request #3975: ReadTheDocs documentation 
for Table Configs, Monitoring, and Deployment
URL: https://github.com/apache/incubator-pinot/pull/3975#discussion_r267902633
 
 

 ##########
 File path: docs/in_production.rst
 ##########
 @@ -40,11 +40,14 @@ Recommended environment
 Deploying Pinot
 ---------------
 
-Direct deployment of Pinot
-~~~~~~~~~~~~~~~~~~~~~~~~~~
+In general, when deploying Pinot services, it is best to adhere to a specific 
ordering in which the various components should be deployed. This deployment 
order is recommended incase of the scenario that there might be protocol or 
other significant differences, the deployments go out in a predictable order in 
which failure  due to these changes can be avoided.
 
 Review comment:
   The requirement section is very vague. Either expand it or take it out 
altogether (but we need to add zk somewhere I suppose). In the recommended 
section, pls add shared storage env mounted across controllers. If this storage 
is not shared, things will not work. Altnerativelyu, pinotfs can be used. (and 
ou can point to a section for that). Not clear what the load baancers are 
needed for. Queries to broker or rest to controlers or both. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to