ly923976094 edited a comment on issue #4006: Controller web cannot create and update schemas URL: https://github.com/apache/incubator-pinot/pull/4006#issuecomment-476460134 > A couple of general notes: please always add unit and integration tests to ensure: > a) Your code works as expected. > b) Your code is future proof-ed against refactors/regressions. > > This section in the contribution guide expects manual testing done to be listed in the PR description: > https://pinot.readthedocs.io/en/latest/contribution_guidelines.html#creating-a-pull-request-pr > > (I will update the contribution guide to include in the description the above 2 points I brought up as well) > A couple of general notes: please always add unit and integration tests to ensure: > a) Your code works as expected. > b) Your code is future proof-ed against refactors/regressions. > > This section in the contribution guide expects manual testing done to be listed in the PR description: > https://pinot.readthedocs.io/en/latest/contribution_guidelines.html#creating-a-pull-request-pr > > (I will update the contribution guide to include in the description the above 2 points I brought up as well) Ok, I'll add the corresponding unit tests later，Unit test has been added and PR needs to be recreated
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
