mcvsubbu commented on issue #4025: Extend stream interfaces to expose message metadata like ingestion timestamp URL: https://github.com/apache/incubator-pinot/pull/4025#issuecomment-477821585 > Why do we have to change the interface of IndexSegment to achieve this? This is creating a circular dependency between the base core and real-time. Conceptually, we have a spi layer (io and segment interfaces) and an offline and real-time module. This change means the base layer depends on an implementation (realtime) layer. > > Is there no other option to achieve this without making changes to the interface? @kishoreg I don;t see a circular dependency. Perhaps I am missing something? The new class is in the generic streams area which is where all the other generic streams classes are.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
