jackjlli opened a new pull request #4054: Refactor ControllerLeaderManager URL: https://github.com/apache/incubator-pinot/pull/4054 This PR refactors `ControllerLeaderManager` by using dependency injection instead of singleton. The purposes of doing this are: * it's clear to know where the object comes from. * the object is still initialized only once and is passed to all the callers. * controller code can easily be tested, e.g more than 1 pinot controller can be instantiated in one test. * singleton pattern is never explicitly freed (implicitly freed on program termination).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
