sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271912337
########## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/MessageBatch.java ########## @@ -18,11 +18,17 @@ */ package org.apache.pinot.core.realtime.stream; +import org.apache.pinot.annotations.InterfaceAudience; +import org.apache.pinot.annotations.InterfaceStability; + + /** * Interface wrapping stream consumer. Throws IndexOutOfBoundsException when trying to access a message at an * invalid index. * @param <T> */ [email protected] [email protected] Review comment: Based on this definition of stable: "Can evolve while retaining compatibility for minor release boundaries.; * can break compatibility only at major release (ie. at m.0)." and the fact that we expect external users to extend this interface, I think we can call it stable. Evolving annotation would be used for anything we are still figuring out - for ex, a first draft of an interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
