codecov-io edited a comment on issue #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#issuecomment-465449456 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=h1) Report > Merging [#3849](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/5618e3f315bfac864e358702f2b5af1f76b58794?src=pr&el=desc) will **decrease** coverage by `0.5%`. > The diff coverage is `88.23%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3849 +/- ## ============================================ - Coverage 67.21% 66.71% -0.51% Complexity 20 20 ============================================ Files 1033 1035 +2 Lines 51338 51445 +107 Branches 7181 7198 +17 ============================================ - Hits 34509 34320 -189 - Misses 14448 14765 +317 + Partials 2381 2360 -21 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...i/resources/PinotSegmentUploadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZFJlc3RsZXRSZXNvdXJjZS5qYXZh) | `69.01% <88.23%> (+1.19%)` | `0 <0> (ø)` | :arrow_down: | | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `0% <0%> (-88.28%)` | `0% <0%> (ø)` | | | [...ache/pinot/transport/conf/TransportClientConf.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZi9UcmFuc3BvcnRDbGllbnRDb25mLmphdmE=) | `0% <0%> (-66.67%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-59.43%)` | `0% <0%> (ø)` | | | [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `13.63% <0%> (-52.28%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `26.74% <0%> (-50%)` | `0% <0%> (ø)` | | | [...e/pinot/transport/config/ConnectionPoolConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL0Nvbm5lY3Rpb25Qb29sQ29uZmlnLmphdmE=) | `0% <0%> (-45%)` | `0% <0%> (ø)` | | | [...pache/pinot/transport/config/ThreadPoolConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL1RocmVhZFBvb2xDb25maWcuamF2YQ==) | `0% <0%> (-33.34%)` | `0% <0%> (ø)` | | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | | | [...che/pinot/transport/config/RoutingTableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL1JvdXRpbmdUYWJsZUNvbmZpZy5qYXZh) | `0% <0%> (-20%)` | `0% <0%> (ø)` | | | ... and [38 more](https://codecov.io/gh/apache/incubator-pinot/pull/3849/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=footer). Last update [5618e3f...745eb75](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
