npawar commented on a change in pull request #4078: Reduce logging in controller
URL: https://github.com/apache/incubator-pinot/pull/4078#discussion_r272420068
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
##########
@@ -225,14 +228,13 @@ public TableSubTypeSizeDetails
getTableSubtypeSize(String tableNameWithType, int
.setValueOfTableGauge(tableNameWithType,
ControllerGauge.TABLE_STORAGE_EST_MISSING_SEGMENT_PERCENT,
missingPercent);
if (subTypeSizeDetails.missingSegments == numSegments) {
- LOGGER.warn("Failed to get size report for all {} segments: {} for
table: {}", numSegments, missingSegments,
- tableNameWithType);
+ LOGGER.warn("Failed to get size report for all {} segments of table:
{}", numSegments, tableNameWithType);
subTypeSizeDetails.reportedSizeInBytes = -1;
subTypeSizeDetails.estimatedSizeInBytes = -1;
} else {
- LOGGER
- .warn("Missing size report for {} out of {} segments: {} for table
{}", subTypeSizeDetails.missingSegments,
- numSegments, missingSegments, tableNameWithType);
+ LOGGER.warn("Missing size report for {} out of {} segments for table
{}. Listing up to {} segments: {}",
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
