This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 58a926e Reduce logging in controller (#4078)
58a926e is described below
commit 58a926e994a4928609d003d35f2a1cfaf878a1ad
Author: Neha Pawar <[email protected]>
AuthorDate: Fri Apr 5 09:20:30 2019 -0700
Reduce logging in controller (#4078)
---
.../pinot/controller/helix/core/retention/RetentionManager.java | 4 ++--
.../java/org/apache/pinot/controller/util/TableSizeReader.java | 9 ++++-----
.../controller/validation/OfflineSegmentIntervalChecker.java | 9 +++++----
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
index b9f2bd5e..b5595e7 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
@@ -118,7 +118,7 @@ public class RetentionManager extends
ControllerPeriodicTask<Void> {
}
}
if (!segmentsToDelete.isEmpty()) {
- LOGGER.info("Deleting segments: {} from table: {}", segmentsToDelete,
offlineTableName);
+ LOGGER.info("Deleting {} segments from table: {}",
segmentsToDelete.size(), offlineTableName);
_pinotHelixResourceManager.deleteSegments(offlineTableName,
segmentsToDelete);
}
}
@@ -147,7 +147,7 @@ public class RetentionManager extends
ControllerPeriodicTask<Void> {
}
}
if (!segmentsToDelete.isEmpty()) {
- LOGGER.info("Deleting segments: {} from table: {}", segmentsToDelete,
realtimeTableName);
+ LOGGER.info("Deleting {} segments from table: {}",
segmentsToDelete.size(), realtimeTableName);
_pinotHelixResourceManager.deleteSegments(realtimeTableName,
segmentsToDelete);
}
}
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
index 527c979..8b9b624 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
@@ -47,6 +47,7 @@ import org.slf4j.LoggerFactory;
*/
public class TableSizeReader {
private static final Logger LOGGER =
LoggerFactory.getLogger(TableSizeReader.class);
+
private final Executor _executor;
private final HttpConnectionManager _connectionManager;
private final PinotHelixResourceManager _helixResourceManager;
@@ -225,14 +226,12 @@ public class TableSizeReader {
.setValueOfTableGauge(tableNameWithType,
ControllerGauge.TABLE_STORAGE_EST_MISSING_SEGMENT_PERCENT,
missingPercent);
if (subTypeSizeDetails.missingSegments == numSegments) {
- LOGGER.warn("Failed to get size report for all {} segments: {} for
table: {}", numSegments, missingSegments,
- tableNameWithType);
+ LOGGER.warn("Failed to get size report for all {} segments of table:
{}", numSegments, tableNameWithType);
subTypeSizeDetails.reportedSizeInBytes = -1;
subTypeSizeDetails.estimatedSizeInBytes = -1;
} else {
- LOGGER
- .warn("Missing size report for {} out of {} segments: {} for table
{}", subTypeSizeDetails.missingSegments,
- numSegments, missingSegments, tableNameWithType);
+ LOGGER.warn("Missing size report for {} out of {} segments for table
{}", subTypeSizeDetails.missingSegments,
+ numSegments, tableNameWithType);
}
} else {
_controllerMetrics
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
index b01aa27..31b01fd 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentIntervalChecker.java
@@ -81,18 +81,19 @@ public class OfflineSegmentIntervalChecker extends
ControllerPeriodicTask<Void>
SegmentsValidationAndRetentionConfig validationConfig =
tableConfig.getValidationConfig();
if (numSegments >= 2 &&
StringUtils.isNotEmpty(validationConfig.getTimeColumnName())) {
List<Interval> segmentIntervals = new ArrayList<>(numSegments);
- List<String> segmentsWithInvalidInterval = new ArrayList<>();
+ int numSegmentsWithInvalidIntervals = 0;
for (OfflineSegmentZKMetadata offlineSegmentZKMetadata :
offlineSegmentZKMetadataList) {
Interval timeInterval = offlineSegmentZKMetadata.getTimeInterval();
if (timeInterval != null &&
TimeUtils.timeValueInValidRange(timeInterval.getStartMillis()) && TimeUtils
.timeValueInValidRange(timeInterval.getEndMillis())) {
segmentIntervals.add(timeInterval);
} else {
-
segmentsWithInvalidInterval.add(offlineSegmentZKMetadata.getSegmentName());
+ numSegmentsWithInvalidIntervals ++;
}
}
- if (!segmentsWithInvalidInterval.isEmpty()) {
- LOGGER.warn("Table: {} has segments with invalid interval: {}",
offlineTableName, segmentsWithInvalidInterval);
+ if (numSegmentsWithInvalidIntervals > 0) {
+ LOGGER.warn("Table: {} has {} segments with invalid interval",
offlineTableName,
+ numSegmentsWithInvalidIntervals);
}
Duration frequency =
convertToDuration(validationConfig.getSegmentPushFrequency());
numMissingSegments = computeNumMissingSegments(segmentIntervals,
frequency);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
