xiaohui-sun commented on a change in pull request #4067: [TE] Holt Winters
detector
URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r272782188
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/HoltWintersDetectorSpec.java
##########
@@ -0,0 +1,75 @@
+package org.apache.pinot.thirdeye.detection.spec;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import org.apache.pinot.thirdeye.dataframe.util.MetricSlice;
+
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+public class HoltWintersDetectorSpec extends AbstractSpec {
+
+ private double alpha = -1;
+ private double beta = -1;
+ private double gamma = -1;
+ private int period = 7;
+ private double sensitivity = 5;
+ private String pattern = "UP_OR_DOWN";
+ private String kernelSmoothing = "true";
Review comment:
Why boolean is string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
