Jackie-Jiang opened a new pull request #4100: Refactor HelixBrokerStarter to separate constructor and start() URL: https://github.com/apache/incubator-pinot/pull/4100 For the starter class, constructor should only set the properies, but not start the service, which should be done by start() instead. - Refactor HelixBrokerStarter to separate constructor and start() - Remove redundant configs, always use constant for configs - Modify shutdown() to shut done all components properly NOTE: THIS IS A BACKWARD-INCOMPATIBLIE CHANGE - Need to call start() separately in order to start the broker - Order of arguments changed in constructor (move nullable to the last. This is intentional so that user can find the imcompatible easier during compilation, thus add the start())
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
