jackjlli opened a new pull request #4102: Cleanup singletons for 2 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102 This PR cleans up singletons for `PinotLLCRealtimeSegmentManager` and `SegmentCompletionManager`. The benefits are: * `SegmentCompletionManager` should be injected instead of using a singleton pattern. * `PinotLLCRealtimeSegmentManager` should be put inside HelixResourceManager (right now these two code are mixed together). * Basically singleton shouldn't be created and explicitly freed. * Singleton isn't the only way to identify there's only 1 object. Using instanceId to differentiate controller processes should be good enough.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
