mcvsubbu commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-482214064 Not sure what prompted the checkin. What was the use case that needed exit? In my case, when I tried this last time, I was just trying to be a correct UNIX command that exits with 0 if successful, 1 otherwise. This would help (I thought) write scripts, so that (for example) we could start up multiple components in independent jvms. bind them to differnt ports, and have a cluster set up. I suggest that we decide this on a per-command basis. e.g. StarZookeeper should jsut run as a daemon. No choice. So, if we set an appropriate variable while coming in from pinot-admin.sh we should be good? Otherwise, a -daemon flag will suffice, but it will funny to add a flag for the obvious (e.g. startzk)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
