jihaozh commented on a change in pull request #4067: [TE] Holt Winters detector
URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r274768750
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
##########
@@ -179,7 +179,8 @@
private static final Set<String> TUNING_OFF_COMPONENTS =
ImmutableSet.of("MIGRATED_ALGORITHM_FILTER", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE");
private static final Map<String, String> DETECTOR_TO_BASELINE =
- ImmutableMap.of("ALGORITHM", "ALGORITHM_BASELINE", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE");
+ ImmutableMap.of("ALGORITHM", "ALGORITHM_BASELINE", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE",
Review comment:
I'm thinking to generalize the multiple inheritance approach (baseline
provider and detector implemented by the same class) in all detector
implementations, as you did in this Hot Winters implementation. After that,
hard code this shouldn't be necessary anymore. So this hack should go away soon
^^. Thank you for making a great example!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
