xiaohui-sun commented on a change in pull request #4067: [TE] Holt Winters
detector
URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275162324
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
##########
@@ -179,7 +179,8 @@
private static final Set<String> TUNING_OFF_COMPONENTS =
ImmutableSet.of("MIGRATED_ALGORITHM_FILTER", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE");
private static final Map<String, String> DETECTOR_TO_BASELINE =
- ImmutableMap.of("ALGORITHM", "ALGORITHM_BASELINE", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE");
+ ImmutableMap.of("ALGORITHM", "ALGORITHM_BASELINE", "MIGRATED_ALGORITHM",
"MIGRATED_ALGORITHM_BASELINE",
Review comment:
Yes this is hacky and let's think of how to get rid of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
