Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276069821
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/builder/BasePartitionAwareRoutingTableBuilder.java ########## @@ -18,6 +18,7 @@ */ package org.apache.pinot.broker.routing.builder; +import it.unimi.dsi.fastutil.ints.IntArrays; Review comment: We use this library for high performance code (use primitive type instead of Object). Both ways are okay because it's query level operations, but we can still call this thousands of times per second. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
