codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start() URL: https://github.com/apache/incubator-pinot/pull/4100#issuecomment-481500729 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=h1) Report > Merging [#4100](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d889dbd0c2b2baa840e0da602592b3bdc1d76155?src=pr&el=desc) will **decrease** coverage by `16.44%`. > The diff coverage is `58.67%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4100 +/- ## ============================================= - Coverage 66.94% 50.49% -16.45% Complexity 20 20 ============================================= Files 1036 1159 +123 Lines 51418 58412 +6994 Branches 7190 8110 +920 ============================================= - Hits 34420 29495 -4925 - Misses 14631 26732 +12101 + Partials 2367 2185 -182 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `20% <ø> (-15.56%)` | `0 <0> (ø)` | | | [...g/apache/pinot/tools/perf/PerfBenchmarkDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya0RyaXZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../pinot/tools/admin/command/StartBrokerCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRCcm9rZXJDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...pinot/server/starter/helix/HelixServerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeFNlcnZlclN0YXJ0ZXIuamF2YQ==) | `0% <0%> (-54.99%)` | `0 <0> (ø)` | | | [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `68.42% <100%> (-17.3%)` | `0 <0> (ø)` | | | [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `14.89% <50%> (-0.33%)` | `0 <0> (ø)` | | | [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `68% <50%> (-1.08%)` | `0 <0> (ø)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `63.97% <57.95%> (-12.7%)` | `0 <0> (ø)` | | | [...inot/broker/queryquota/TableQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9UYWJsZVF1ZXJ5UXVvdGFNYW5hZ2VyLmphdmE=) | `65.16% <71.42%> (-4.32%)` | `0 <0> (ø)` | | | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `47.96% <81.81%> (-40.97%)` | `0 <0> (ø)` | | | ... and [461 more](https://codecov.io/gh/apache/incubator-pinot/pull/4100/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=footer). Last update [d889dbd...51bacdd](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
