jackjlli commented on a change in pull request #4102: Cleanup singletons for 3
classes in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276509840
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
##########
@@ -84,12 +81,15 @@ public static int getMaxCommitTimeForAllSegmentsSeconds() {
// TODO keep some history of past committed segments so that we can avoid
looking up PROPERTYSTORE if some server comes in late.
- protected SegmentCompletionManager(HelixManager helixManager,
PinotLLCRealtimeSegmentManager segmentManager,
- ControllerMetrics controllerMetrics, ControllerLeadershipManager
controllerLeadershipManager) {
+ public SegmentCompletionManager(HelixManager helixManager,
PinotLLCRealtimeSegmentManager segmentManager,
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
