xiaohui-sun commented on a change in pull request #4147: Add upper lower bounds
URL: https://github.com/apache/incubator-pinot/pull/4147#discussion_r277094792
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spi/model/TimeSeries.java
##########
@@ -53,17 +53,47 @@ public void addPredictedBaseline(DoubleSeries
baselineValues) {
this.df.addSeries(DataFrameUtils.COL_VALUE, baselineValues);
}
+ /**
+ * Add the predicted upper bound into the timeseries
+ * @param upperBoundValues predicted upper bound values
+ */
+ public void addPredictedUpperBound(DoubleSeries upperBoundValues) {
Review comment:
As discussed. Changed the constructors to handle it more efficiently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
