jihaozh commented on a change in pull request #4148: [TE] detection - two side
threshold filter
URL: https://github.com/apache/incubator-pinot/pull/4148#discussion_r277107279
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/PercentageChangeRuleAnomalyFilterSpec.java
##########
@@ -21,9 +21,11 @@
public class PercentageChangeRuleAnomalyFilterSpec extends AbstractSpec {
private String timezone = "UTC";
- private double threshold = Double.NaN;
private String offset;
private String pattern= "UP_OR_DOWN";
+ private double threshold = 0.0; // by default set threshold to 0 to pass all
anomalies
+ private double upThreshold = Double.NaN;
Review comment:
Most of the filters are one side unless the threshold is overridden by
upThreshold or downThreshold. If they are not NaN, then we know it's
overridden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
