jihaozh commented on a change in pull request #4149: [TE] support monitoring
granularity for Holt Winters
URL: https://github.com/apache/incubator-pinot/pull/4149#discussion_r277397046
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/components/HoltWintersDetector.java
##########
@@ -514,6 +561,10 @@ private static double sensitivityToZscore(double
sensitivity) {
return z;
}
+ private boolean isMultiDayGranularity() {
Review comment:
maybe add a comment here. for example. check if the granularity is daily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]