mcvsubbu commented on a change in pull request #4156: Refactor
HelixExternalViewBasedTimeBoundaryService to support all time units
URL: https://github.com/apache/incubator-pinot/pull/4156#discussion_r277559283
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -428,8 +428,7 @@ private BrokerRequest
getRealtimeBrokerRequest(BrokerRequest hybridBrokerRequest
private void attachTimeBoundary(String rawTableName, BrokerRequest
brokerRequest, boolean isOfflineRequest) {
TimeBoundaryService.TimeBoundaryInfo timeBoundaryInfo =
_timeBoundaryService.getTimeBoundaryInfoFor(TableNameBuilder.OFFLINE.tableNameWithType(rawTableName));
- if (timeBoundaryInfo == null || timeBoundaryInfo.getTimeColumn() == null
- || timeBoundaryInfo.getTimeValue() == null) {
+ if (timeBoundaryInfo == null) {
Review comment:
if we skipped setting the time boundary as in line 110 of
HelixExternalviewBasedTimeBoundaryService.java, then is it still guaranteed
that timeBoundaryInfo.getTimeValue() is non-null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
