Jackie-Jiang commented on a change in pull request #4159: Add multiple locks
which can be obtained based on segment name in lookupOrCreateFSM
URL: https://github.com/apache/incubator-pinot/pull/4159#discussion_r278242296
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java
##########
@@ -90,6 +95,8 @@ public SegmentCompletionManager(HelixManager helixManager,
PinotLLCRealtimeSegme
_controllerLeadershipManager = controllerLeadershipManager;
SegmentCompletionProtocol
.setMaxSegmentCommitTimeMs(TimeUnit.MILLISECONDS.convert(segmentCommitTimeoutSeconds,
TimeUnit.SECONDS));
+ _fsmLocks = new Lock[NUM_FSM_LOCKS];
+ Arrays.fill(_fsmLocks, new ReentrantLock());
Review comment:
This will fill all locks with the same lock object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
