jihaozh commented on a change in pull request #4161: [TE] anomalies endpoint to
work with new baseline provider
URL: https://github.com/apache/incubator-pinot/pull/4161#discussion_r278269958
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/AnomaliesResource.java
##########
@@ -1130,10 +1130,17 @@ private AnomalyDetails
constructAnomalyDetails(MergedAnomalyResultDTO anomaly, D
.withStart(new DateTime(sliceAnomalyCurrent.getStart(),
dataTimeZone).minus(offsets.getPreOffsetPeriod()).getMillis())
.withEnd(new DateTime(sliceAnomalyCurrent.getEnd(),
dataTimeZone).plus(offsets.getPostOffsetPeriod()).getMillis());
- DataFrame dfCurrent = this.timeSeriesLoader.load(sliceViewCurrent);
DataFrame dfBaseline = DetectionUtils.getBaselineTimeseries(anomaly,
filters, metric.getId(), config, sliceViewCurrent.getStart(),
sliceViewCurrent.getEnd(), this.loader, this.provider).getDataFrame();
- DataFrame dfAligned = dfCurrent.renameSeries(COL_VALUE,
COL_CURRENT).joinOuter(
- dfBaseline.renameSeries(COL_VALUE, COL_BASELINE));
+ DataFrame dfAligned;
+ if (dfBaseline.contains(COL_CURRENT)) {
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
