xiaohui-sun commented on a change in pull request #4166: [TE] add threshold for
dimension explore
URL: https://github.com/apache/incubator-pinot/pull/4166#discussion_r278760021
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java
##########
@@ -197,12 +206,29 @@ public DetectionPipelineResult run() throws Exception {
nestedMetrics = nestedMetrics.stream().filter(metricEntity ->
checkMinLiveZone(metricEntity)).collect(Collectors.toList());
}
+ return nestedMetrics;
+ }
+
+ @Override
+ public DetectionPipelineResult run() throws Exception {
+ List<MetricEntity> nestedMetrics = dimensionExplore();
+ if (nestedMetrics.isEmpty()) {
+ return new
DetectionPipelineResult(Collections.<MergedAnomalyResultDTO>emptyList(), -1);
+ }
+ if (nestedMetrics.size() > MAX_DIMENSION_COMBINATIONS) {
+ throw new DetectionPipelineException(String.format(
Review comment:
I would prefer to fail it explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
