jihaozh commented on a change in pull request #4167: [TE] Show more debug
information in preview
URL: https://github.com/apache/incubator-pinot/pull/4167#discussion_r278779483
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -576,7 +576,7 @@ public Response yamlPreviewApi(
Map<String, Object> newDetectionConfigMap = new
HashMap<>(ConfigUtils.getMap(this.yaml.load(payload)));
DetectionConfigDTO detectionConfig =
buildDetectionConfigFromYaml(tuningStart, tuningEnd, newDetectionConfigMap,
null);
Preconditions.checkNotNull(detectionConfig);
- detectionConfig.setId(Long.MAX_VALUE);
+ detectionConfig.setId(0L);
Review comment:
I remember we had some issues before to set this to 0. Could we keep this
unchanged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]