Jackie-Jiang commented on a change in pull request #4169: Update Audience and Stability annotations for basic classes URL: https://github.com/apache/incubator-pinot/pull/4169#discussion_r279088633
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandler.java ########## @@ -21,11 +21,15 @@ import com.fasterxml.jackson.databind.JsonNode; import javax.annotation.Nullable; import javax.annotation.concurrent.ThreadSafe; +import org.apache.pinot.annotations.InterfaceAudience; +import org.apache.pinot.annotations.InterfaceStability; import org.apache.pinot.broker.api.RequestStatistics; import org.apache.pinot.broker.api.RequesterIdentity; import org.apache.pinot.common.response.BrokerResponse; [email protected] [email protected] Review comment: Let's not annotate this class for now. I don't know if start() and shutDown() should be in the interface ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
