Jackie-Jiang commented on a change in pull request #4170: Make realtime server
upload timeout configurable
URL: https://github.com/apache/incubator-pinot/pull/4170#discussion_r279090838
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java
##########
@@ -40,7 +40,8 @@
*/
public class ServerSegmentCompletionProtocolHandler {
private static Logger LOGGER =
LoggerFactory.getLogger(ServerSegmentCompletionProtocolHandler.class);
- private static final int SEGMENT_UPLOAD_REQUEST_TIMEOUT_MS = 30_000;
+ private static final int DEFAULT_SEGMENT_UPLOAD_REQUEST_TIMEOUT_MS = 300_000;
+ private static final String CONFIG_OF_SEGMENT_UPLOAD_REQUEST_TIMEOUT_MS =
"upload.request.timeout.ms";
Review comment:
Can you move these into CommonConstants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
