xiaohui-sun commented on a change in pull request #4168: [TE] Clean up
anomalyTimelinesView for anomalies order than 90 days
URL: https://github.com/apache/incubator-pinot/pull/4168#discussion_r279100539
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/monitor/MonitorTaskRunner.java
##########
@@ -108,6 +111,28 @@ private void executeMonitorUpdate(MonitorTaskInfo
monitorTaskInfo) {
}
}
+ private int cleanUpMergedAnomalies(int cleanUpDays) {
+ DateTime cleanupStartDate = new
DateTime().withTimeAtStartOfDay().minusDays(cleanUpDays);
+ DateTime cleanupEndDate = cleanupStartDate.plusDays(1);
Review comment:
Good points.
By looking at the last successful monitoring job is also not robust since
this clean may fail as well.
Will add more buffer but still want to make it lightweight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
