Jackie-Jiang commented on a change in pull request #4173: Reduce ZK access
URL: https://github.com/apache/incubator-pinot/pull/4173#discussion_r279516348
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -101,8 +101,9 @@ public void run() {
protected synchronized void deleteSegmentFromPropertyStoreAndLocal(String
tableName, Collection<String> segmentIds,
long deletionDelay) {
// Check if segment got removed from ExternalView and IdealStates
Review comment:
Can you replace 'and' with 'or' to reflect the code correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
