sunithabeeram commented on a change in pull request #4175: Set forceDelete to
false for deleteTaskQueue
URL: https://github.com/apache/incubator-pinot/pull/4175#discussion_r279941322
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
##########
@@ -139,11 +140,19 @@ public synchronized void resumeTaskQueue(@Nonnull String
taskType) {
*
* @param taskType Task type
*/
- public synchronized void deleteTaskQueue(@Nonnull String taskType) {
+ public synchronized void deleteTaskQueue(@Nonnull String taskType)
+ throws InterruptedException {
String helixJobQueueName = getHelixJobQueueName(taskType);
LOGGER.info("Deleting task queue: {} for task type: {}",
helixJobQueueName, taskType);
- // NOTE: set force delete to true to remove the task queue from ZooKeeper
immediately
- _taskDriver.delete(helixJobQueueName, true);
+ // NOTE: set force delete to true to remove the task queue from ZooKeeper
immediately.
Review comment:
The comments here don't see to make sense. Can you remove them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
