Jackie-Jiang commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r280647948
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/kafka/KafkaStreamLevelConsumer.java
##########
@@ -87,11 +88,12 @@ public GenericRow next(GenericRow destination) {
return next(destination, null);
}
+ // NOTE: currently metadata is not updated as the simple consumer does not
expose the relevant information
@Override
- public GenericRow next(GenericRow destination, StreamMessageMetadata
metadata) {
+ public GenericRow next(GenericRow destination, RowMetadata metadata) {
Review comment:
Please remove this API and keep the old one (without passing in
RowMetadata). If we have to return metadata from this method in the future, we
can put metadata into GenericRow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
