Jackie-Jiang commented on a change in pull request #3979: Track "freshness" timestamp across consuming segments URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r280647451
########## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/StreamMessageMetadata.java ########## @@ -18,24 +18,22 @@ */ package org.apache.pinot.core.realtime.stream; -import org.apache.pinot.annotations.InterfaceAudience; -import org.apache.pinot.annotations.InterfaceStability; +import org.apache.pinot.common.metadata.RowMetadata; /** * A class that provides metadata associated with the message of a stream, for e.g., * ingestion-timestamp of the message. */ [email protected] [email protected] -public class StreamMessageMetadata { +public class StreamMessageMetadata implements RowMetadata { Review comment: Let's rename this to DefaultRowMetadata or StreamRowMetadata? In the future we might want to make this class support more types of metadata ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
