snleee commented on a change in pull request #4139: Migration to log4j2
URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281811063
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java
##########
@@ -52,6 +52,10 @@ private ZookeeperInstance(PublicZooKeeperServerMain
serverMain, String dataDirPa
@Override
public void initializeAndRun(String[] args)
throws QuorumPeerConfig.ConfigException, IOException {
+ // org.apache.log4j.jmx.* is not compatible under log4j-1.2-api, which
provides the backward compatibility for
+ // log4j 1.* api for log4j2. In order to avoid 'class not found error',
the following line disables log4j jmx
+ // bean registration for local zookeeper instance
+ System.setProperty("zookeeper.jmx.log4j.disable", "true");
Review comment:
I think that we should still keep `log4j-1.2-api` since some of our
dependencies are directly using log4j 1.x api (e.g. zookeeper). Zookeeper is
still on log4j 1.x so using later version won't help here. There was some
effort to do migration but the pr didn't get merged and closed.
https://github.com/apache/zookeeper/pull/148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
