Jackie-Jiang commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r282201459
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
##########
@@ -129,13 +129,11 @@ public File initializeStatsHistory() {
// create mutable segment impl
MutableSegmentImpl mutableSegmentImpl = new
MutableSegmentImpl(realtimeSegmentConfigBuilder.build());
- StreamMessageMetadata messageMetadata = new StreamMessageMetadata();
+ StreamMessageMetadata messageMetadata = new
StreamMessageMetadata(System.currentTimeMillis());
Review comment:
We can simply pass in **null** here right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
