Jackie-Jiang commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r282200706
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplTest.java
##########
@@ -89,6 +93,11 @@ public void testMetadata() {
SegmentMetadata expectedSegmentMetadata =
_immutableSegment.getSegmentMetadata();
Assert.assertEquals(actualSegmentMetadata.getTotalDocs(),
expectedSegmentMetadata.getTotalDocs());
+ // assert that the last indexed timestamp is close to what we expect
+ long actualTs =
_mutableSegmentImpl.getSegmentMetadata().getLastIndexedTimestamp();
Review comment:
Do you also want to test if last ingestion time matches the default metadata
time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
