Jackie-Jiang commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r282202406
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -212,17 +212,16 @@ public void run() {
int numRowsErrored = 0;
GenericRow consumedRow = null;
- StreamMessageMetadata messageMetadata = new StreamMessageMetadata();
do {
try {
consumedRow = GenericRow.createOrReuseRow(consumedRow);
- messageMetadata.reset();
- consumedRow = _streamLevelConsumer.next(consumedRow,
messageMetadata);
+ consumedRow = _streamLevelConsumer.next(consumedRow);
if (consumedRow != null) {
GenericRow transformedRow =
_recordTransformer.transform(consumedRow);
if (transformedRow != null) {
- notFull = realtimeSegment.index(transformedRow,
messageMetadata);
+ // we currently do not get ingestion data through
stream-consumer
+ notFull = realtimeSegment.index(transformedRow, new
StreamMessageMetadata(System.currentTimeMillis()));
Review comment:
Pass in **null** as StreamMessageMetadata?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
