Jackie-Jiang commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r282202767
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegment.java
##########
@@ -29,10 +29,10 @@
* Indexes a record into the segment with optionally provided metadata.
*
* @param row Record represented as a {@link GenericRow}
- * @param msgMetadata the metadata associated with the message
+ * @param rowMetadata the metadata associated with the message
* @return Whether the segment is full (i.e. cannot index more record into
it)
*/
- boolean index(GenericRow row, StreamMessageMetadata msgMetadata);
+ boolean index(GenericRow row, RowMetadata rowMetadata);
Review comment:
Can we annotate the RowMetadata as **Nullable**? Also all the implementations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
